Fix flakiness in ProfileTest.EventTraceTruncation. - #586
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_972970666
branch
2 times, most recently
from
August 31, 2026 16:39
b504ed6 to
4e31c90
Compare
In EventTraceTruncation, allocations were performed after an initial SleepFor(20ms), allowing background allocations during the sleep to consume the small trace memory buffer (kEventTraceMemoryLimit = 2048, capacity for only 1 pair) before the early allocation was recorded, causing intermittent truncation of the expected early event. PiperOrigin-RevId: 973933851
copybara-service
Bot
force-pushed
the
test_972970666
branch
from
August 31, 2026 16:51
4e31c90 to
e360731
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flakiness in ProfileTest.EventTraceTruncation.
In EventTraceTruncation, allocations were performed after an initial
SleepFor(20ms), allowing background allocations during the sleep to
consume the small trace memory buffer (kEventTraceMemoryLimit = 2048,
capacity for only 1 pair) before the early allocation was recorded,
causing intermittent truncation of the expected early event.