Fix e2e harness compilation against go-github v89 and go-sdk v1.7 - #3187
Open
ppoffice wants to merge 1 commit into
Open
Fix e2e harness compilation against go-github v89 and go-sdk v1.7#3187ppoffice wants to merge 1 commit into
ppoffice wants to merge 1 commit into
Conversation
The e2e test package no longer compiled under --tags e2e because it lagged behind two dependency migrations: - go-github v89: NewClient now returns (*Client, error) and WithEnterpriseURLs moved from a *Client method to a ClientOptionsFunc. Update getRESTClient and the inline cleanup call sites, and drop the trailing nil options arg from ListReviewers. - go-sdk v1.7: ghmcp.NewMCPServer(MCPServerConfig) was replaced by ghmcp.NewStdioMCPServer(ctx, github.MCPServerConfig). Update the in-process setupMCPClient branch accordingly, supplying the required Logger and Version fields.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused compatibility updates correctly preserve existing E2E behavior.
Pull request overview
Updates the build-tagged E2E harness for current go-github and MCP SDK APIs.
Changes:
- Migrates REST client creation and reviewer listing to go-github v89.
- Migrates in-process server setup to
NewStdioMCPServer.
File summaries
| File | Description |
|---|---|
e2e/e2e_test.go |
Restores E2E harness compilation with updated dependency APIs. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The e2e test package no longer compiles under --tags e2e, so the e2e suite cannot run at all. It lagged behind two dependency migrations that landed on main:
Because the package only builds with --tags e2e, this breakage was invisible to the default CI build.
Changes
All in e2e/e2e_test.go:
il options arg (removed in v89).
Verification
Not run against the live API here (needs a GITHUB_MCP_SERVER_E2E_TOKEN + Docker).