Fix spurious check_token_telemetry failure in Smoke Cursor workflow#57313
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot reconfigure cursor.md to |
Looked into this before making further changes: Separately, even if cursor-agent could be redirected, the AWF api-proxy's So routing Cursor through api-proxy isn't achievable from |
|
Great work, The changes are focused and well-explained:
The PR looks ready for review and merge. Nice alignment with the project's workflow patterns! Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See Network Configuration for more information.
|
|
Category: bug | Risk: medium | Score: 46/100 (impact 16/50, urgency 14/30, quality 16/20) | Action: defer | Batch: workflow-automation
|
|
Category: bug | Risk: medium | Score: 46/100 (impact 16/50, urgency 14/30, quality 16/20) | Action: defer | Batch: workflow-automation
|
The
check_token_telemetryjob in the Smoke Cursor workflow was failing on every run becausetoken_usage.jsonlwas always empty for Cursor.api2.cursor.sh) directly rather than through gh-aw's universal LLM provider proxy, so it never producestoken_usage.jsonl. The telemetry check assumes proxy-routed engines and was misapplied here.shared/token-telemetry-check.mdimport fromsmoke-cursor.md, aligning it withshared/aider.mdand other direct-API engines that already omit this check for the same reason.smoke-cursor.lock.ymlviagh aw compile, which drops the now-unneededcheck_token_telemetryjob.