Skip to content

[SDK/Factories] Add Factory Pagination And Completion Options - #2431

Open
MRayermannMSFT wants to merge 4 commits into
mainfrom
mrayermannmsft-agent-factory-pagination
Open

[SDK/Factories] Add Factory Pagination And Completion Options#2431
MRayermannMSFT wants to merge 4 commits into
mainfrom
mrayermannmsft-agent-factory-pagination

Conversation

@MRayermannMSFT

Copy link
Copy Markdown
Contributor

What

The Node.js Agent Factories API adds paginated run listing with cursor and truncation metadata. Factory run and resume options now forward completion notifications and phase-name logging.

Why

SDK callers can inspect complete run history without raw RPC calls. This pull request is stacked on #2430 because that pull request provides the generated Copilot CLI 1.0.81 contract.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Base automatically changed from update-copilot-1.0.81 to main August 27, 2026 23:09
@MRayermannMSFT
MRayermannMSFT force-pushed the mrayermannmsft-agent-factory-pagination branch from 55dffc6 to 79b0f32 Compare August 27, 2026 23:12
@github-actions

This comment has been minimized.

@MRayermannMSFT
MRayermannMSFT marked this pull request as ready for review August 27, 2026 23:30
@MRayermannMSFT
MRayermannMSFT requested a review from a team as a code owner August 27, 2026 23:30
Copilot AI balanced review requested due to automatic review settings August 27, 2026 23:30
@MRayermannMSFT MRayermannMSFT added the post-to-slack Post PR to reviewers Slack channel label Aug 27, 2026
@MRayermannMSFT
MRayermannMSFT marked this pull request as draft August 27, 2026 23:31
@MRayermannMSFT MRayermannMSFT removed the post-to-slack Post PR to reviewers Slack channel label Aug 27, 2026
@MRayermannMSFT
MRayermannMSFT marked this pull request as ready for review August 27, 2026 23:32
@MRayermannMSFT MRayermannMSFT added the post-to-slack Post PR to reviewers Slack channel label Aug 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

Review tier: Balanced
Findings: None

What changed in this PR

Adds Node.js Agent Factories pagination metadata and runtime completion/phase controls.

Changes:

  • Adds paginated listRuns overloads while preserving the array-returning API.
  • Forwards notification and phase logging options for runs and resumes.
  • Documents and tests the new behavior.
File Description
nodejs/​src/​factory.ts Defines pagination types and runtime options.
nodejs/​src/​session.ts Implements pagination and option forwarding.
nodejs/​src/​index.ts Exports pagination types.
nodejs/​src/​extension.ts Exports pagination types for extensions.
nodejs/​docs/​factories.md Documents the new API.
nodejs/​test/​factory.test.ts Tests RPC forwarding and response shapes.
nodejs/​test/​e2e/​factory.e2e.test.ts Tests pagination and runtime controls end to end.
nodejs/​test/​e2e/​fixtures/​factory-extension.mjs Adds a phased E2E factory fixture.
CHANGELOG.md Records the feature additions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@MRayermannMSFT
MRayermannMSFT force-pushed the mrayermannmsft-agent-factory-pagination branch from 79b0f32 to d38d8c0 Compare August 28, 2026 07:01
@github-actions

This comment has been minimized.

@MRayermannMSFT
MRayermannMSFT force-pushed the mrayermannmsft-agent-factory-pagination branch from d38d8c0 to 894a4f8 Compare August 29, 2026 07:01
@github-actions

This comment has been minimized.

MRayermannMSFT and others added 4 commits August 31, 2026 00:00
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@MRayermannMSFT
MRayermannMSFT force-pushed the mrayermannmsft-agent-factory-pagination branch from 894a4f8 to b99d753 Compare August 31, 2026 07:01
@github-actions

Copy link
Copy Markdown
Contributor

Cross-SDK Consistency Review ✅

This PR adds paginated listRuns() and notifyOnComplete/logPhaseNames options to the Node.js Agent Factories convenience API, which is Node.js-only at this time.

Findings

No cross-SDK consistency issues. Here's why:

  1. Underlying RPC types are already consistent: The generated RPC types (FactoryListRunsRequest, FactoryListRunsResult, notifyOnComplete, logPhaseNames on RunOptions/FactoryResumeRequest) already exist in all six SDK generated layers — Python (generated/rpc.py), Go (rpc/zrpc.go), .NET (Generated/Rpc.cs), and the contract is shared.

  2. The SessionFactoryApi high-level convenience layer is Node.js-only by design: The other SDKs (Python, Go, .NET, Java, Rust) expose factory operations only via raw RPC — there is no equivalent session.factory.listRuns() wrapper in those SDKs yet. The CHANGELOG correctly scopes this to "Node.js Agent Factories convenience API."

  3. The new options (notifyOnComplete, logPhaseNames) are passed through to the CLI via RPC fields that are already generated in all SDKs — so callers of the raw RPC APIs in other languages can already use these options today.

Summary

The PR maintains parity at the RPC contract level and adds Node.js-specific convenience ergonomics on top of an already Node.js-only factory session API surface. No changes needed in other SDKs.

Generated by SDK Consistency Review Agent for #2431 · sonnet46 41.6 AIC · ⌖ 5.47 AIC · ⊞ 6.6K ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

post-to-slack Post PR to reviewers Slack channel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants