fix(fees,credit_notes,invoices,taxes): align models with the API contract - #418
Merged
Conversation
…ract Fee no longer exposes invoice_display_name, which the fees controller does not permit on update, and FeeResponse drops unit_amount_cents, invoice_display_name and billing_entity_code, none of which the serializer emits, in favour of the fields it does. CreditNote regains the create fields the controller permits and taxes_amount_cents is typed as the integer it is. TaxResponse and InvoiceResponse gain the fields their serializers always emit.
Compare floats with pytest.approx and use the or operator in place of a ternary. The CI action installs whatever ruff is latest at run time, so the preview rules added in 0.16.5 broke every branch.
rsempe
approved these changes
Sep 2, 2026
toommz
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fee no longer exposes invoice_display_name, which the fees controller does not permit on update, and FeeResponse drops unit_amount_cents, invoice_display_name and billing_entity_code, none of which the serializer emits, in favour of the fields it does. CreditNote regains the create fields the controller permits and taxes_amount_cents is typed as the integer it is. TaxResponse and InvoiceResponse gain the fields their serializers always emit.