Move FileIO table labels into marker schemas - #6296
Open
fatadel wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6296 +/- ##
========================================
Coverage 83.82% 83.83%
========================================
Files 350 350
Lines 37744 37761 +17
Branches 10646 10543 -103
========================================
+ Hits 31638 31656 +18
+ Misses 5677 5676 -1
Partials 429 429 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
canova
requested changes
Sep 3, 2026
canova
left a comment
canova
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! Before I review completely, I see that this PR does 2 main things:
- Adds optional segment syntax to marker labels
- Adds a tableLabel to FileIO markers
It's difficult to review these two changes when they are combined together. Can you please split them into 2 commits?
Contributor
Author
Done ✅ |
Marker label templates currently interpolate surrounding text even when a referenced payload field is absent. Let templates wrap optional content in `[[` and `]]` so punctuation and other text can be omitted with the missing value.
Replace the hardcoded `data.type` branch in the generic label fallback with a template on the FileIO schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
Replace the hardcoded
data.typebranch that assembles FileIO table labels with a schema template. Optional segments let the template omit surrounding punctuation when source or filename fields are missing.Closes #6295
Profile with IO enabled