Move timeline marker styles into marker schemas - #6293
Open
fatadel wants to merge 2 commits into
Open
Conversation
Marker styles use methods to resolve theme-dependent colors, which cannot be serialized as marker schema metadata. Store only color data in each style and resolve it when drawing timeline markers.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6293 +/- ##
==========================================
+ Coverage 83.82% 83.83% +0.01%
==========================================
Files 350 350
Lines 37744 37742 -2
Branches 10646 10647 +1
==========================================
+ Hits 31638 31641 +3
+ Misses 5677 5672 -5
Partials 429 429 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Bug for the Gecko side - https://bugzilla.mozilla.org/show_bug.cgi?id=2068137. |
Timeline rendering selects styles from a hardcoded table keyed by marker `data.type`. Putting the style in each schema removes that type-specific lookup and lets producers define marker appearance.
canova
removed their request for review
September 3, 2026 14:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
Timeline marker styles are currently selected from a hardcoded table keyed by marker
data.type. The style objects also contain methods, so they cannot be stored as marker schema metadata.This PR makes marker styles serializable and stores them in marker schemas. Timeline rendering now reads styles from the schemas, while preserving marker-name overrides.
Profile processing and the processed-profile upgrader derive the existing styles for schemas without this metadata. A follow-up Gecko change will populate the style field in Gecko marker schemas.
Closes #6292
Profile