馃悰 Fix return 401 instead of 404 when a token's user doesn't exist - #2474
Open
ErikH-move wants to merge 1 commit into
Open
馃悰 Fix return 401 instead of 404 when a token's user doesn't exist#2474ErikH-move wants to merge 1 commit into
ErikH-move wants to merge 1 commit into
Conversation
get_current_user returned 404 when the user id it encoded no longer existed. 404 is the wrong code since nothing about the requested resource is missing, the presented credential is just invalid. An issue with the 404 code was that the frontend's global error handler only clears and redirects to login on 401/403.
YuriiMotov
changed the title
Member
|
I agree 401 is correct status code here. @ErikH-move, could you please add a test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_current_user returned 404 when the user id it encoded no longer existed. 404 is the wrong code since nothing about the requested resource is missing, the presented credential is just invalid. An issue with the 404 code was that the frontend's global error handler only clears and redirects to login on 401/403.