Preserve numeric 0 in YAML directive options - #49
Open
BetterAndBetterII wants to merge 1 commit into
Open
Conversation
parseDirectiveOptions stringified option values with `|| ""`, so YAML numeric 0 became an empty string and nonnegative_int threw "Value is not set". Use nullish coalescing so 0 is kept; null/false still map to empty string first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseDirectiveOptionsstringified YAML option values with`${converted_value || ""}`. YAML/yaml.loadturnsheader-rows: 0(and:header-rows: 0) into numeric0, which is falsy, so the convertor received""andnonnegative_intthrewOptionSpecError: Value is not set.Switch to nullish coalescing so
0is preserved.null/falseare still mapped to""before conversion, matching the previous flag/empty-option behavior.Named cases:
header-rows: 0onlist-tableno longer throws:header-rows: 0no longer throws:header-rows: 1still builds<thead>Fixes #33