Prevent resuming a saved preset - #4228
Open
ZenAlexa wants to merge 1 commit into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Author
|
The focused preset tests, Ruff checks, and Pyright pass on the current head. The fork workflow is |
Author
|
Thanks for enabling the fork workflow. The full |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4204.
What changed
dstack preset resumeonce the session has a committedpreset.yml; cleanup may leavesession.jsonatrunning,interrupted, orfailedinterrupted/faileddisplay statesWhy
PresetStore.save()atomically commits the verified artifact before run cleanup. Cleanup is already best-effort and cannot invalidate that artifact, so its interruption must not make the completed creation resumable. A genuinely interrupted session with no saved preset keeps the existing resume behavior.Verification
uv run pytest -q src/tests/_internal/cli/services/presets src/tests/_internal/cli/commands/test_preset.py— 312 passed, 2 skippeduv run ruff checkanduv run ruff format --checkon the changed filesuvx pyright --pythonpath .venv/bin/python -p .— 0 errors