formatter: add raw byte sizes for images - #7276
Open
mrmayurgithub wants to merge 1 commit into
Open
Conversation
Signed-off-by: Mayur Agarwal <64331623+mrmayurgithub@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Added exact
SizeBytes,SharedSizeBytes, andUniqueSizeBytesvalues to the image formatter. Related to #5300.- How I did it
docker image ls --format jsoncurrently returns rounded strings such as"72.9MB"or"N/A". The new fields expose the underlying byte counts as JSON numbers, ornullwhen unavailable. Existing human-readable fields remain unchanged.- How to verify it
Run:
GOCACHE=/private/tmp/docker-cli-go-cache ./scripts/with-go-mod.sh go test ./cli/command/formatterThe formatter test verifies exact values, unique-size calculation, unavailable values, and preservation of the existing
Sizeoutput.- Human readable description for the release notes