update naturalsort sorting with slice - #7269
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
4044fe5 to
6dc2fa8
Compare
docker-agent
left a comment
There was a problem hiding this comment.
⚠️ Review incomplete
chunk 1: Drafter did not complete
chunk 2: Drafter did not complete
chunk 3: Drafter did not complete
All three drafter delegations failed with a sub-agent schema validation error (output_config.format.schema: Unsupported regex feature). The automated hypothesis-generation pipeline could not run.
Manual inspection summary (orchestrator-level): The diff was reviewed directly. This PR is a clean mechanical migration from sort.Slice/sort.Sort to slices.SortFunc/slices.SortStableFunc in tandem with vendoring github.com/fvbommel/sortorder v1.2.0 (which adds NaturalCompare for three-way comparison). All comparator semantics were verified to be preserved correctly:
sort.Slice→slices.SortFuncconversions: comparator directions correct throughout.sort.SliceStable/sort.Stable→slices.SortStableFunc: stability preserved.slices.SortedFunc(maps.Values(emptyMap), ...)returnsnilin Go 1.24, so theupdateUlimits"remove all" test expectation (nil) remains satisfied.cmp.Or/cmp.Compareport-sort replacements match the original field ordering.formatAdminRolekey-ID sort now creates a copy instead of mutating the receiver — a bug fix.toStringList%s→%vformat change is safer for non-stringanyvalues.filepath.IsLocalpath-escape check incli/config/config.gois more robust than the oldstrings.HasPrefixapproach.
No bugs were identified in the manual pass. However, since the automated pipeline did not complete, this review cannot be treated as a full automated review.
Findings so far:
6dc2fa8 to
b7a8460
Compare
b7a8460 to
904816a
Compare
full diff: fvbommel/sortorder@v1.1.0...v1.2.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
904816a to
ab53eb6
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
ab53eb6 to
07c8f47
Compare
vendor: github.com/fvbommel/sortorder v1.2.0
full diff: fvbommel/sortorder@v1.1.0...v1.2.0
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)