Retire promoted release candidates older than the newest two - #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Stops the releases page from filling up with old release candidates. Every ship promotes a
rolling-candidate-<build>prerelease torolling, but nothing ever deleted the promoted candidates, so nine of them (110 MB each) were sitting there this morning. After this change each successful ship deletes promoted candidates older than the two newest, keeping the current build and one previous build for rollback.Summary
scripts/publish_rolling_release.sh: newretire_promoted_candidates, run once after a successful promotion. It deletes published, non-immutable candidates with a build strictly lower than the finalized one, except the newestPROGRAMA_RETAINED_CANDIDATES(default 2), usinggh release delete --cleanup-tagso the tag goes too. The draft-only prune on the drift-repair path is unchanged.tests/test_rolling_release_publication.sh: two new cases, default window andPROGRAMA_RETAINED_CANDIDATES=1. All release shell tests and the 209 node tests pass.Test plan