Fix rolling release promotion after the daemon removal - #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Unblocks the rolling release. The first ship after #329 failed in the promote step because the release validator now expects four assets per sealed candidate, and the previous candidate still on GitHub, the one the live appcast points at, has the old ten. The validator now accepts that legacy shape, so main can ship again.
Summary
scripts/rolling_release_state.js: the sixprogramad-remote-*names are a valid legacy immutable set. A sealed manifest passes with 4 assets (current) or 10 (legacy, all six present). A partial legacy set fails with its own message.rolling-candidate-33540975688001001manifest: throws before, validates after.node --test scripts/*.test.jsand the three release shell tests pass.Test plan