feat: support key rotation period and bypass safety check - #53
Open
RoseSecurity wants to merge 1 commit into
Open
feat: support key rotation period and bypass safety check#53RoseSecurity wants to merge 1 commit into
RoseSecurity wants to merge 1 commit into
Conversation
Add variables for custom key rotation period and option to bypass the policy lockout safety check in KMS key resource. Update outputs and resource definitions to use Terraform 0.12+ idioms.
RoseSecurity
requested review from
Jeremy White (dudymas) and
PePe Amengual (jamengual)
May 22, 2026 19:39
Member
Author
|
/terratest |
Kevin (kevcube)
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
rotation_period_in_daysto allow custom KMS key rotation periods.bypass_policy_lockout_safety_checkto support KMS policies that require bypassing AWS lockout safety validation.one()expressions.why
references