Skip to content

Revert "Move wrapper handle to shim" and add a regression test - #7227

Open
ObsidianMinor wants to merge 1 commit into
mainfrom
revert-2d08fd1
Open

Revert "Move wrapper handle to shim" and add a regression test#7227
ObsidianMinor wants to merge 1 commit into
mainfrom
revert-2d08fd1

Conversation

@ObsidianMinor

Copy link
Copy Markdown
Contributor

This reverts commit 2d08fd1.

@ObsidianMinor
ObsidianMinor requested review from a team as code owners September 3, 2026 05:03
@ask-bonk

ask-bonk Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

@ObsidianMinor Bonk workflow was cancelled.

View workflow run · To retry, trigger Bonk again.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.27273% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.31%. Comparing base (8352890) to head (f027730).

Files with missing lines Patch % Lines
src/workerd/jsg/wrappable.c++ 79.06% 3 Missing and 6 partials ⚠️
src/workerd/jsg/isolate-shutdown-test.c++ 93.02% 0 Missing and 3 partials ⚠️
src/workerd/jsg/setup.c++ 88.88% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7227      +/-   ##
==========================================
- Coverage   37.32%   37.31%   -0.02%     
==========================================
  Files         801      801              
  Lines      251478   251435      -43     
  Branches    20000    19981      -19     
==========================================
- Hits        93857    93815      -42     
- Misses     146250   146263      +13     
+ Partials    11371    11357      -14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants