Avoid destroying in-memory alarm tasks while running - #7215
Open
xThreeh wants to merge 1 commit into
Open
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an in-memory Durable Object alarm completes, cleanup can clear the preview task while its callback is still running. That destroys the active promise callback and aborts workerd with Promise callback destroyed itself. Defer the task cleanup to the next event-loop turn instead. Added a regression test covering an empty alarm handler with in-memory storage. Tests: bazel test //src/workerd/api/tests:actor-alarms-in-memory-test@; bazel test //src/workerd/api/tests:actor-alarms-test@; python tools/cross/format.py --check git. Fixes #7190