Skip to content

CC-8364 Expose configured container images to Durable Objects - #7194

Merged
skepticfx merged 1 commit into
mainfrom
nafeez/CC-8364-container-images-api
Sep 4, 2026
Merged

CC-8364 Expose configured container images to Durable Objects#7194
skepticfx merged 1 commit into
mainfrom
nafeez/CC-8364-container-images-api

Conversation

@skepticfx

Copy link
Copy Markdown
Member

Carry class-scoped image references into Durable Object actor construction and expose them through the read-only ctx.container.images property. Return a fresh dictionary on each access so Worker code cannot mutate the runtime configuration.

@skepticfx
skepticfx requested review from a team as code owners August 31, 2026 17:48
@skepticfx
skepticfx requested a review from emily-shen August 31, 2026 17:48
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Comment thread src/workerd/server/server.c++ Outdated
@ask-bonk

ask-bonk Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

I'm Bonk, and I've done a quick review of your PR.

Adds ctx.container.images backed by configured container image metadata.

  1. High src/workerd/server/server.c++:4128 always passes an empty dictionary, so configured Durable Objects expose {}. Posted inline.

github run

@skepticfx
skepticfx force-pushed the nafeez/CC-8364-container-images-api branch from 7a734ac to 6194b78 Compare August 31, 2026 18:18
@skepticfx
skepticfx requested a review from a team as a code owner August 31, 2026 18:18
@skepticfx
skepticfx force-pushed the nafeez/CC-8364-container-images-api branch from 6194b78 to b6d8c42 Compare August 31, 2026 18:45
@skepticfx

Copy link
Copy Markdown
Member Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Aug 31, 2026
@ask-bonk

ask-bonk Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@skepticfx
skepticfx force-pushed the nafeez/CC-8364-container-images-api branch 3 times, most recently from b08ca34 to eae4044 Compare September 1, 2026 05:07
@skepticfx
skepticfx force-pushed the nafeez/CC-8364-container-images-api branch 5 times, most recently from 3523db9 to e5d8a63 Compare September 4, 2026 17:55
Carry class-scoped image references into Durable Object actor construction and expose them through the read-only ctx.container.images property. Return a fresh dictionary on each access so Worker code cannot mutate the runtime configuration.
@skepticfx
skepticfx force-pushed the nafeez/CC-8364-container-images-api branch from e5d8a63 to 0d55e4e Compare September 4, 2026 18:25
@skepticfx
skepticfx enabled auto-merge September 4, 2026 18:42
@skepticfx
skepticfx merged commit 7a46b19 into main Sep 4, 2026
22 of 23 checks passed
@skepticfx
skepticfx deleted the nafeez/CC-8364-container-images-api branch September 4, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants