Instrument LOG_EXCEPTION to observe a new Sentry disposition exception detail - #7185
Conversation
|
I'm Bonk, and I've done a quick review of your PR. Adds Sentry disposition details to
|
7004dd4 to
926896e
Compare
926896e to
a7cc7a3
Compare
|
LGTM |
a7cc7a3 to
40c987b
Compare
40c987b to
3f3578b
Compare
|
Seems OK to me, at least. I guess maybe worth noting that the change will probably affect the sentry fingerprints of existing exceptions, such that events will be recorded in new issues, but that's true of many code changes. Might be worth adding a few samples of the new exception content to the internal sentry-handler library tests to verify that they submit the expected content. |
e7fdc98 to
329def1
Compare
Both issues fixed (fingerprint changes avoided and tests added) on this internal MR: https://gitlab.cfdata.org/cloudflare/ew/edgeworker/-/merge_requests/14737 (sorry to outside viewers for not getting to see) |
329def1 to
6ad4b16
Compare
…n detail This will allow us to set NOSENTRY or SENTRY_DO or SENTRY_RT or similar on specific messages, designating how we handle these errors or what development team they go to, without adding strings to exception messages. Also tie wdErrId fields more directly to the appropriate name.
6ad4b16 to
699bbd3
Compare
|
trivial rebases ^ |
This will allow us to set NOSENTRY or SENTRY_DO or SENTRY_RT or similar on specific messages, designating how we handle these errors or what development team they go to, without adding strings to exception messages.
Also tie wdErrId fields more directly to the appropriate name.