Add sockets streams suite - #7180
Merged
Merged
Conversation
Contributor
|
I'm Bonk, and I've done a quick review of your PR. Adds a dual-implementation socket-streams test suite with TCP echo sidecars.
Verification could not complete: Bazel lacks libc++ headers in this runner. |
jasnell
force-pushed
the
jasnell/streams-test-consolidation-9
branch
from
September 3, 2026 18:36
40cc902 to
39b4c14
Compare
jasnell
force-pushed
the
jasnell/streams-test-consolidation-9
branch
from
September 3, 2026 18:46
39b4c14 to
fe4baa9
Compare
jasnell
force-pushed
the
jasnell/streams-test-consolidation-9
branch
from
September 3, 2026 22:00
fe4baa9 to
9d7a541
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7180 +/- ##
==========================================
- Coverage 37.56% 37.33% -0.24%
==========================================
Files 801 801
Lines 253637 251822 -1815
Branches 20021 20021
==========================================
- Hits 95286 94011 -1275
+ Misses 146993 146453 -540
Partials 11358 11358 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jasnell
force-pushed
the
jasnell/streams-test-consolidation-9
branch
3 times, most recently
from
September 4, 2026 01:51
ee6cacd to
a2e1b94
Compare
jasnell
force-pushed
the
jasnell/streams-test-consolidation-9
branch
from
September 4, 2026 03:03
a2e1b94 to
73b7cfb
Compare
dom96
approved these changes
Sep 4, 2026
jasnell
force-pushed
the
jasnell/streams-test-consolidation-9
branch
from
September 4, 2026 13:59
73b7cfb to
84ae294
Compare
jasnell
force-pushed
the
jasnell/streams-test-consolidation-9
branch
from
September 4, 2026 18:12
84ae294 to
02127fb
Compare
Base automatically changed from
jasnell/streams-test-consolidation-8
to
main
September 4, 2026 19:28
jasnell
force-pushed
the
jasnell/streams-test-consolidation-9
branch
4 times, most recently
from
September 4, 2026 20:57
e9b3594 to
ce69dad
Compare
jasnell
force-pushed
the
jasnell/streams-test-consolidation-9
branch
from
September 8, 2026 16:39
ce69dad to
31c33a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More test consolidations.