Skip to content

Add sockets streams suite - #7180

Merged
jasnell merged 2 commits into
mainfrom
jasnell/streams-test-consolidation-9
Sep 8, 2026
Merged

Add sockets streams suite#7180
jasnell merged 2 commits into
mainfrom
jasnell/streams-test-consolidation-9

Conversation

@jasnell

@jasnell jasnell commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

More test consolidations.

@jasnell
jasnell requested review from a team as code owners August 28, 2026 23:01
Comment thread src/tests/streams/sockets/socket-streams.js Outdated
@ask-bonk

ask-bonk Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

I'm Bonk, and I've done a quick review of your PR.

Adds a dual-implementation socket-streams test suite with TCP echo sidecars.

  1. Medium cancelReadableSettlesSocket does not exercise cancellation of a live read. Posted one inline suggestion to correct it.

Verification could not complete: Bazel lacks libc++ headers in this runner.

github run

@jasnell
jasnell force-pushed the jasnell/streams-test-consolidation-9 branch from 40cc902 to 39b4c14 Compare September 3, 2026 18:36
@jasnell
jasnell force-pushed the jasnell/streams-test-consolidation-9 branch from 39b4c14 to fe4baa9 Compare September 3, 2026 18:46
@jasnell
jasnell requested review from guybedford and npaun September 3, 2026 18:48
@jasnell
jasnell force-pushed the jasnell/streams-test-consolidation-9 branch from fe4baa9 to 9d7a541 Compare September 3, 2026 22:00
@codecov-commenter

codecov-commenter commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.33%. Comparing base (6637171) to head (31c33a2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7180      +/-   ##
==========================================
- Coverage   37.56%   37.33%   -0.24%     
==========================================
  Files         801      801              
  Lines      253637   251822    -1815     
  Branches    20021    20021              
==========================================
- Hits        95286    94011    -1275     
+ Misses     146993   146453     -540     
  Partials    11358    11358              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnell
jasnell force-pushed the jasnell/streams-test-consolidation-9 branch 3 times, most recently from ee6cacd to a2e1b94 Compare September 4, 2026 01:51
@jasnell
jasnell force-pushed the jasnell/streams-test-consolidation-9 branch from a2e1b94 to 73b7cfb Compare September 4, 2026 03:03
@jasnell
jasnell force-pushed the jasnell/streams-test-consolidation-9 branch from 73b7cfb to 84ae294 Compare September 4, 2026 13:59
@jasnell
jasnell force-pushed the jasnell/streams-test-consolidation-9 branch from 84ae294 to 02127fb Compare September 4, 2026 18:12
Base automatically changed from jasnell/streams-test-consolidation-8 to main September 4, 2026 19:28
@jasnell
jasnell force-pushed the jasnell/streams-test-consolidation-9 branch 4 times, most recently from e9b3594 to ce69dad Compare September 4, 2026 20:57
@jasnell
jasnell force-pushed the jasnell/streams-test-consolidation-9 branch from ce69dad to 31c33a2 Compare September 8, 2026 16:39
@jasnell
jasnell merged commit d3c7030 into main Sep 8, 2026
22 of 27 checks passed
@jasnell
jasnell deleted the jasnell/streams-test-consolidation-9 branch September 8, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants