Fix textWidth cache check and optimize segment style caching - #12295
Open
Zynviro wants to merge 3 commits into
Open
Fix textWidth cache check and optimize segment style caching#12295Zynviro wants to merge 3 commits into
Zynviro wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces performance optimizations and a logic fix in canvas helpers:
src/helpers/helpers.canvas.ts: Updated the text width cache check in_measureTextto usetypeof textWidth === 'undefined'instead of a loose falsy check. This ensures a text width of0is properly stored rather than repeatedly forcing a re-measurement.src/helpers/helpers.segment.js: Replaced an array.includes()lookup in the segment style cache replacer with a higher-performanceMapimplementation to optimize style serialization tracking.Changes Made
Mapstructure for tracking pattern/gradient style caching.