Skip to content

ISLE: Veri: include counterexample in CI log for failures - #14269

Queued
avanhatt wants to merge 4 commits into
bytecodealliance:mainfrom
avanhatt:counterexample
Queued

ISLE: Veri: include counterexample in CI log for failures#14269
avanhatt wants to merge 4 commits into
bytecodealliance:mainfrom
avanhatt:counterexample

Conversation

@avanhatt

@avanhatt avanhatt commented Sep 2, 2026

Copy link
Copy Markdown
Member

Include counterexamples when verification fails in the CI log (capped at 25 total).

For example, failure log now includes:

==========================
Cache mode:         ReadWrite
Cache source:       cranelift/isle/veri/cache
Cache destination:  cranelift/isle/veri/cache.rebuild
=== VERIFICATION FAILURES (4) ===
FAILURE #4	cranelift/codegen/src/opts/arithmetic.isle line 23	(instantiation 0)	.veriisle/expansions/00004/000/failure.out
#4	cranelift/codegen/src/opts/arithmetic.isle line 23	instantiation=0
model:
state: relax_nan = false
state: clif_trap = false
state: clif_load = {active: false, size_bits: 0, addr: #x0000000000000000}
state: clif_store = {active: false, size_bits: 1, addr: #x0000000000000000, value: #x0000000000000000}
state: loaded_value = #x0000000000000000
iadd({bits: 8}, #x40, #xdf) -> #x1f
ineg({bits: 8}, #x21) -> #xdf
isub({bits: 8}, #x21, #x40) -> #xe1
simplify(#x1f) -> #xe1

@avanhatt
avanhatt marked this pull request as ready for review September 2, 2026 19:27
@avanhatt
avanhatt requested review from a team as code owners September 2, 2026 19:27
@avanhatt
avanhatt requested review from alexcrichton and cfallin and removed request for a team September 2, 2026 19:27
@github-actions github-actions Bot added cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language labels Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Subscribe to Label Action

cc @avanhatt, @cfallin, @fitzgen, @mmcloughlin

Details This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

  • avanhatt: isle
  • cfallin: isle
  • fitzgen: isle
  • mmcloughlin: isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@cfallin cfallin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like a submodule change to tests/component-model got caught in the diff too (git submodule update before committing, I often forget too...) -- happy to merge once that's fixed!

@alexcrichton
alexcrichton added this pull request to the merge queue Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants