Replace almost every manually-written AliasRegions helper method with macro-generated versions - #14267
Merged
cfallin merged 4 commits intoSep 3, 2026
Conversation
`VMStoreContext::component_context` and `VMDeferredThread::saved_context` are both `[u32; NUM_COMPONENT_CONTEXT_SLOTS]`, accessed one element at a time by a compile-time constant index. This allows us to remove a bunch of hand-written helpers for these types.
This commit adds support for generating accessors of data that we have a pointer to in the vmctx, rather than storing inline in the vmctx, by describing the pointed-at data in a `#[pointee(..)]` attribute. This allows us to remove a number of hand-written helpers for things like the type ids array and builtin functions array which are pointed at from the `vmctx` rather than inline in it.
This moves `VMDrcHeapData`, `VMCopyingHeapData`, and the null collector's bump pointer into the `for_each_vm_type!` macro so that we get macro-generated offsets, alias region helpers, and struct definitions for them. This removes a bunch of manually-written offsets and alias region helpers.
github-actions
Bot
added
wasmtime:api
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "wasmtime:api", "wasmtime:ref-types", "winch"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See each commit for details.
All that is remaining after this is stack-switching related stuff.