Add BooleanArray array assertions via the array template. - #582
Open
mpawliszyn wants to merge 3 commits into
Open
Add BooleanArray array assertions via the array template.#582mpawliszyn wants to merge 3 commits into
mpawliszyn wants to merge 3 commits into
Conversation
Note that the documentation uses numbers as examples but they are still representative of the expected behaviour.
mpawliszyn
force-pushed
the
boolean-array
branch
2 times, most recently
from
August 31, 2026 15:32
d34079b to
54ca095
Compare
Each process is likely around 3GB and the box has 8GB, so limit it to 2 instead of 4 to saturate the 4 vCPUs.
mpawliszyn
force-pushed
the
boolean-array
branch
from
August 31, 2026 15:42
54ca095 to
9f76e2b
Compare
Author
|
😓 Finally got a green build. I'll split out the CI fixes too. It may make sense to move off of the canary node which I think also requires a move to kotlin 2.0 (although we should be able to also set |
This was referenced Aug 31, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that the documentation uses numbers as examples but they are still representative of the expected behaviour.
Based on the forensics I did BooleanArray appears to be simply missed during development. Also note that I had to adapt the tests to the boolean values rather than using the number array templating directly.
I added documentation that references the templated tests. Let me know if you want me to add a back-reference in the templates as well. I could see wanting that going either way.
I did run all the tests locally on my mac as best I could on everything that does not require xcode.