chore: bump undici from 7.29.0 to 8.10.0 - #699
Open
dependabot[bot] wants to merge 3 commits into
Open
Conversation
Bumps [undici](https://github.com/nodejs/undici) from 7.29.0 to 8.10.0. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v7.29.0...v8.10.0) --- updated-dependencies: - dependency-name: undici dependency-version: 8.10.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
undici 8's ProxyAgent only tunnels http:-scheme requests through CONNECT when proxyTunnel is set; WebSocket support rewrites ws(s): to http(s): before dispatching, so it was silently forwarded instead of tunneled, breaking the Upgrade handshake through the proxy under test. ProxyAgent also passes the proxy's literal hostname as the TLS servername for HTTPS main-proxy connections, which Node rejects for IP literals (the tests always address the main proxy by 127.0.0.1). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
@bliuchak Not sure if we want to do this bump. Undici 8 requires node 22 and locally if you run As it's just a dev dependency, we could just bump the Dockerfile version and remove node 20 from |
Contributor
Author
|
A newer version of undici exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
VojtaM39
added
the
t-unblocking
daniil-poletaev
approved these changes
Sep 4, 2026
| } | ||
| return new ProxyAgent({ uri: proxy.origin, token, connectTimeout, requestTls: tls, proxyTls: tls }); | ||
|
|
||
| // `undici`'s WebSocket support rewrites ws(s): to http(s): before dispatching, so a `ws:` |
Contributor
There was a problem hiding this comment.
(nit): I would prefer simple 1 sentence comments. Don't like those essays 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps undici from 7.29.0 to 8.10.0.
Release notes
Sourced from undici's releases.
... (truncated)
Commits
c8d80e6Bumped v8.10.0 (#5644)66923b4fix: preserve DNS origin hostname on sockets (#5577)3926499fix: retry refused HTTP/2 streams (#5598)73d6e9efix(h2): detach upgrade close handler after GOAWAY (#5641)b111adbfix(mock): emit request body lifecycle hooks (#5367)ae4a3e3build(deps): bump actions/setup-node from 6.4.0 to 7.0.0 (#5636)ec3fbf1build(deps): bump github/codeql-action/init from 4.36.2 to 4.37.3 (#5634)2151720build(deps): bump ossf/scorecard-action from 2.4.3 to 2.4.4 (#5633)b96a116fix(interceptors): allow interceptors without opts.origin (#5628)a18ef2dfix(mock): non-string path matchers under ignoreTrailingSlash, and DataView r...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)