docs(security): document PERMISSION_INSTRUCTIONS_LINK templating - #43901
Open
rusackas wants to merge 1 commit into
Open
docs(security): document PERMISSION_INSTRUCTIONS_LINK templating#43901rusackas wants to merge 1 commit into
rusackas wants to merge 1 commit into
Conversation
#41843 added templated {datasource_id}/{datasource_name}/{table_names}/{username} placeholders to PERMISSION_INSTRUCTIONS_LINK so the "Request access" link on data-permission errors can deep-link into an org's access-request tool, but the security config docs only described roles/permissions in general terms. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Code Review Agent Run #a9d42cActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
github-actions
Bot
added
doc
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
#41843 (merged) added templated
{datasource_id},{datasource_name},{table_names}, and{username}placeholders toPERMISSION_INSTRUCTIONS_LINK, so the "Request access" link on data-permission errors can deep-link into an org's access-request tool with the denied resource pre-filled. The security config docs only described roles/permissions in general terms and never mentioned this. Adding a short section to the admin security docs covering the config and its placeholders.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A, docs-only change.
TESTING INSTRUCTIONS
Read
docs/admin_docs/security/security.mdxand confirm the new "Actionable Access-Denied Messages" section (under "Managing Data Source Access for Gamma Roles") accurately reflects the behavior insuperset/security/manager.py's_render_permission_instructions_link.ADDITIONAL INFORMATION
Co-Authored-By: Claude noreply@anthropic.com