[iceberg] Refuse types the mirror cannot publish before the commit or the replace - #9477
Draft
plusplusjiajia wants to merge 2 commits into
Draft
[iceberg] Refuse types the mirror cannot publish before the commit or the replace#9477plusplusjiajia wants to merge 2 commits into
plusplusjiajia wants to merge 2 commits into
Conversation
plusplusjiajia
force-pushed
the
gh-iceberg-veto-unsupported-types
branch
from
August 30, 2026 13:34
3313d14 to
0c38c87
Compare
plusplusjiajia
marked this pull request as ready for review
August 30, 2026 13:35
plusplusjiajia
marked this pull request as draft
August 30, 2026 14:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Blob and vector columns have no Iceberg type, and variant needs format version 3, but the mirror only finds out inside IcebergDataField while converting a schema it has already been told to publish, so the snapshot is durable by then and every later commit keeps failing the same way; this validates the same rule where the timestamp and time rules already run, on the current schema at DDL time and on the whole schema history when the mirror is enabled on an existing table, so the refusal lands before the commit instead of after it, and the conversion-layer checks stay as backstops for tables created before this guard.
replaceTable drops or truncates the table it replaces before the new schema reaches the validation in SchemaManager, and neither is undone when that validation refuses the schema, so a replacement carrying one of these types took the old data with it; this judges the replacement schema, directives expanded, before either destructive step, which also covers every other rule validateTableSchema enforces