feat(file-index): support additional types and validate decimal scale - #271
Open
zjw1111 wants to merge 4 commits into
Open
feat(file-index): support additional types and validate decimal scale#271zjw1111 wants to merge 4 commits into
zjw1111 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #173
Extend file-index read/write support while keeping serialized data compatible with Java Paimon, and prevent silent DECIMAL index misfiltering at table entry points:
Tests
API and Format
No public API signatures are changed. TableScan and TableRead now reject DECIMAL predicate literals with a scale different from the schema, or a value that does not fit the field precision. Direct index-reader APIs retain their existing behavior and now document the same-scale requirement.
The bitmap, BSI, and range-bitmap formats are extended to the additional logical types without changing their format versions. Floating-point bitmap keys are verified against Java-generated V1/V2 bytes.
Documentation
Add public FileIndexReader and GlobalIndexReader notes requiring DECIMAL literals passed to Visit* to use the indexed field scale.
Generative AI tooling
Generated-by: OpenAI Codex (GPT-5).