[GLUTEN-12858][TEST] Unpersist cached DataFrames in flatten test - #12929
Open
sliortega295-ops wants to merge 1 commit into
Open
[GLUTEN-12858][TEST] Unpersist cached DataFrames in flatten test#12929sliortega295-ops wants to merge 1 commit into
sliortega295-ops wants to merge 1 commit into
Conversation
Generated-by: OpenAI Codex (GPT-5)
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Wrap each cached branch of the
flatten functiontest intry/finallyand unpersist its DataFrame after the cached assertions complete. The same lifecycle fix is applied to the Spark 3.3, 3.4, 3.5, 4.0, and 4.1 suites.Previously, each version left three DataFrames cached for the rest of the suite. The updated test keeps at most one of these relations cached and releases it on both success and assertion failure, reducing unnecessary CPU-memory pressure and order sensitivity.
Fixes #12858.
How was this patch tested?
test-compilereactor: 12/12 modules passed,BUILD SUCCESSjavapconfirmed all three normal and exceptional paths callDataset.unpersist()cache, 3try, 3finally, and 3unpersistcallsgit diff --check: passedThe JNI runtime suite was not run because this checkout has no prebuilt
libgluten.so; building the native backend exceeds the available 30 GiB host-memory budget. The repository-wide formatter was also attempted but is currently blocked by a pre-existing formatting error in untouchedgluten-iceberg/.../IcebergLocalFilesNode.java; all five touched modules pass their focused Spotless checks.No GPU was used or required.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-5)
The implementation and this description were generated at the account owner's request. Codex re-checked the final diff against repository code and ran the validations listed above. No separate human line-by-line code review was performed before submission.