[spark] Support ADD COLUMN in Spark catalog - #4174
Open
Xtpacz wants to merge 4 commits into
Open
Conversation
Author
Yohahaha
reviewed
Sep 3, 2026
Yohahaha
left a comment
Yohahaha
left a comment
Contributor
There was a problem hiding this comment.
left some comments, thank you!
| throw new UnsupportedOperationException( | ||
| s"Adding nested columns is not supported: ${p.fieldNames().mkString(".")}") | ||
| } | ||
| org.apache.fluss.metadata.TableChange.addColumn( |
Contributor
There was a problem hiding this comment.
do we need support spark ColumnDefaultValue here?
Author
There was a problem hiding this comment.
fluss doesn't support column defaults (no field anywhere in TableChange/Schema), and since we don't implement SupportsColumnDefaultValue
I added a guard, so a future SupportsColumnDefaultValue would fail loudly rather than drop defaults.
any case you think we should handle here?
|
|
||
| protected def lakeFormat: Option[DataLakeFormat] = None | ||
|
|
||
| test("Catalog: add columns") { |
Contributor
There was a problem hiding this comment.
test not cover ColumnPosition, comments, nullable, please enrich test cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
support
alter table ... add columnin fluss-spark catalogBrief change log
AddColumnchanges to fluss table changes.Tests
added a test.
API and Format
no
Documentation
no