[fix](be) Disambiguate duplicate JSONPath leaf columns - #67418
Open
0AyanamiRei wants to merge 1 commit into
Open
[fix](be) Disambiguate duplicate JSONPath leaf columns#674180AyanamiRei wants to merge 1 commit into
0AyanamiRei wants to merge 1 commit into
Conversation
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: JSON table-valued function schema inference used only the final key of each jsonpath as its output column name. Distinct paths such as $.left.id and $.right.id therefore both became id and failed the existing case-insensitive duplicate-column check. Detect duplicate leaf names and derive names from their path context, while preserving the existing leaf-only names for non-conflicting paths.
### Release note
JSON table-valued functions now expose path-qualified column names such as left_id and right_id when selected jsonpaths have duplicate leaf names.
### Check List (For Author)
- Test: BE unit test, regression test, and manual HTTP stream test
- BE unit test: NewJsonReaderSchemaTest.*
- Regression test: test_jsonpaths_duplicate_leaf with left/right controls and combined paths
- Manual test: http_stream loaded 2 rows with left_id, right_id, and city
- BE ASAN build, format check, and build hygiene
- Behavior changed: Yes. Conflicting JSONPath leaf names are qualified with path context.
- Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
TPC-H: Total hot run time: 16676 ms |
Contributor
TPC-DS: Total hot run time: 81940 ms |
Contributor
ClickBench: Total hot run time: 14.7 s |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
TPC-H: Total hot run time: 17190 ms |
Contributor
TPC-DS: Total hot run time: 81436 ms |
Contributor
ClickBench: Total hot run time: 14.7 s |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: JSON table-valued function schema inference used only the final key of each
jsonpathas its output column name. Distinct paths such as$.left.idand$.right.idtherefore both becameidand failed the existing case-insensitive duplicate-column check. Detect duplicate leaf names and derive names from their path context, while preserving the existing leaf-only names for non-conflicting paths.Release note
JSON table-valued functions now expose path-qualified column names such as
left_idandright_idwhen selected jsonpaths have duplicate leaf names.Check List (For Author)
NewJsonReaderSchemaTest.*test_jsonpaths_duplicate_leafwith left/right controls and combined pathshttp_streamloaded 2 rows withleft_id,right_id, andcitycore/types.hNOLINT and system-header conflicts