perf: avoid clone and sort fast in TopK heap - #24639
Draft
MassivePizza wants to merge 8 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24639 +/- ##
==========================================
+ Coverage 81.48% 81.58% +0.09%
==========================================
Files 1122 1123 +1
Lines 404248 406620 +2372
Branches 404248 406620 +2372
==========================================
+ Hits 329390 331722 +2332
+ Misses 55547 55461 -86
- Partials 19311 19437 +126 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MassivePizza
force-pushed
the
fast-topk-heap
branch
from
August 28, 2026 14:19
2a77d48 to
19f814d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?