Fix models selection in genai tests - #72323
Merged
potiuk merged 1 commit intoSep 8, 2026
Merged
Conversation
boring-cyborg
Bot
added
area:providers
provider:google
VladaZakharova
force-pushed
the
bugfix/fix-models-selection-logic-in-genai-tests
branch
from
September 2, 2026 14:38
fc911ce to
8fb5765
Compare
Contributor
|
@shahar1 hey there :) |
1 task
potiuk
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace automated model selection in genai tests with a simplified approach. Now the models are provided in the environment variables. It will make tests more stable and will allow the team to easily update the models when needed.
I also modified SFT params a bit to make the tuning job faster.
Was generative AI tooling used to co-author this PR?