Post Action Plugin Infrastructure - #277
Open
amd-benprice wants to merge 4 commits into
Open
Conversation
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
post-actions, which is a method of running more plugins based on the granular results of prior plugins. Post actions can be specified only through the plugin configuration JSON file. The README is updated with the specific semantics of how post actions can be configured. Any plugin can be used as a post-action plugin. This PR also adds unit tests for post actions, and updates one existing unit test.This PR also contains a bugfix that prevented OS detection during remote execution. The fix was to not make a
pydanticmodel copy ofsystem_infoinpluginexecutor.py, and instead use the pre-existing instance of the model. The copy would be update with the correct OS family, but the original, which was then passed to the plugins themselves, was not updated, which caused all plugins to not run.Test plan
pytest test/unitpytest test/functional(if applicable)pre-commit run --all-filesChecklist