Fix useTreeData subtree move validation - #10560
Open
su-jin1425 wants to merge 2 commits into
Open
Conversation
su-jin1425
force-pushed
the
fix-usetreedata-move-bug
branch
from
September 3, 2026 10:45
d305b81 to
6bc74bf
Compare
su-jin1425
commented
Sep 3, 2026
|
|
||
| if (!didThrow) { | ||
| expect(console.error).toHaveBeenCalled(); | ||
| const errorString = console.error.mock.calls.flat().join(' '); |
Author
There was a problem hiding this comment.
Added additional Regression test for safety Tell me if you dont want these.
reidbarber
approved these changes
Sep 3, 2026
su-jin1425
force-pushed
the
fix-usetreedata-move-bug
branch
from
September 5, 2026 01:18
6bc74bf to
0153b79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #10539
Summary
Prevent
useTreeDatafrom silently dropping nodes when an item is moved into its own subtree.This adds validation to the imperative
move,moveBefore, andmoveAfterAPIs so that moves targeting a node's own descendants throw:Cannot move an item to be a child of itself.The validation also covers root-level nodes, which were previously missed by
moveBeforeandmoveAfter.Changes
move().moveBefore()andmoveAfter().Pull Request Checklist:
Test Instructions:
Run the
useTreeDatatest suite:The regression tests verify that
move,moveBefore, andmoveAfterthrow when attempting to move an item into its own subtree, including root-level ancestor cases.Your Project:
None