Fix nested popover closing PreviewTrigger on hover - #10484
Open
HamedFarazi wants to merge 5 commits into
Open
Conversation
devongovett
reviewed
Sep 4, 2026
| // To determine if a popover is a descendant, we check if the pointer is in it AND some element | ||
| // within the parent overlay has focus or aria-controls pointing to it. | ||
| if (overlayElement) { | ||
| let allPopovers = document.querySelectorAll('.react-aria-Popover'); |
Member
There was a problem hiding this comment.
This assumes no one set a custom class name on their popovers so it won't work correctly in many cases. I'm also not sure we want to traverse the DOM to determine this. I think we're gonna want to find a way for useTooltipTriggerState to handle this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10443
Summary
Fixes an issue where a nested Popover opened from inside a
PreviewTriggerpopover caused the parentPreviewTriggerpopover to close when moving the pointer into the nested overlay.The issue happened because the nested overlay is rendered outside of the
PreviewTriggerpopover boundary, causing the hover interaction to be interpreted as leaving the preview area.This change adds regression coverage for nested overlays inside
PreviewTriggerand ensures the parent preview remains open while interacting with child overlays.✅ Pull Request Checklist:
📝 Test Instructions:
Automated tests
Run:
yarn jest packages/react-aria-components/test/PreviewTrigger.test.js ## 🧢 Your Project: N/A