Update PHPStan 2.2.13 - #13410
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| $safe_text = (string) preg_replace_callback( | ||
| $regex, | ||
| static function ( $matches ) { | ||
| if ( ! isset( $matches[0] ) ) { |
There was a problem hiding this comment.
fixes
4851 Call to function array_key_exists() with 0 and array{0: string, non_cdata_followed_by_cdata: '', 1: '', 2: '', cdata: '', 3: '', 4: '', non_cdata: string, ...}|array{0:
string, non_cdata_followed_by_cdata: string, 1: string, 2: string, cdata: non-falsy-string, 3: non-falsy-string, 4: non-falsy-string} will always evaluate to true.
🪪 function.alreadyNarrowedType
at src/wp-includes/formatting.php:4851
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
done |
| count: 2 | ||
| path: ../../../src/wp-includes/class-wp-embed.php | ||
| - | ||
| message: '#^Parameter \#1 \$handle of function curl_getinfo expects resource, \(resource\|false\) given\.$#' |
at PHPStan we worked hard to improve performance on recent releases. Updating the tooling makes sure Wordpress can use latest additions and get the best possible PHPStan experience
before this PR (PHPStan 2.2.5)
after this PR (PHPStan 2.2.13)
running on Macbook M4-Pro, PHP 8.5.10 (cli)
=> ~20 seconds faster (wall-time; cold result-cache)
https://core.trac.wordpress.org/ticket/66051