fix: preserve resized dimensions after updateOption - #5301
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Keep row-height recomputation from touching manually resized rows and avoid using a manual row as the representative height for fixed body rows. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Keep defaultHeaderColWidth aligned with defaultColWidth when unset. This prevents updateOption from resetting pivot row headers to 80. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Keep manually resized columns fixed during adaptive width redistribution. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Limit resized-column freezing to adaptive width mode. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateOptionwhile still recalculating unresized columns.developand include the AIME-reviewed fixes from PR fix: preserve pivot column widths after updateOption #5299.Test plan
npx jest __tests__/create-group-for-first-screen-issue-5298.test.ts --runInBand --silent=falsenpm run compile5c21a99bb🤖 Generated with Claude Code