fix: support Ubuntu 26.04 install and Qt timers - #55
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c7989dbf46
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
QTimer.singleShotcallbacks~/.config/blitztext-linux/secrets.envWhy
PyQt 6.11 with Python 3.14 exposed a lifetime bug: a static timer callback could run after
deleteLater()had destroyed the C++ widget, aborting the Python process. Owner-boundQTimerinstances are destroyed with their widgets and prevent the stale callback.The install guidance also described
systemctl --user startas enabling autostart even though the installer already enables the user service. Ubuntu 26.04 ships Python 3.14, so that verified runtime now needs equal CI coverage.Validation
python3 -m compileall app testsQT_QPA_PLATFORM=offscreen WHISPER_GUI_TESTS=1 .venv/bin/python -m pytest -q— 524 passed, 2 skipped on Python 3.14.4tests/test_state_machine.py— 30 passedbash -n scripts/install.sh scripts/verify.shgit diff --checkFlatpak remains an experimental developer spike and is unchanged. PR #54 is handled separately after this PR.