Skip to content

fix: prevent Markdown and Highlight landing link crashes - #1202

Open
KevinVandy wants to merge 1 commit into
mainfrom
fix/1200-library-cross-link-prefetch
Open

fix: prevent Markdown and Highlight landing link crashes#1202
KevinVandy wants to merge 1 commit into
mainfrom
fix/1200-library-cross-link-prefetch

Conversation

@KevinVandy

@KevinVandy KevinVandy commented Aug 31, 2026

Copy link
Copy Markdown
Member

Summary

  • point the Markdown companion card at the dedicated Highlight route template
  • point the Highlight companion card at the dedicated Markdown route template
  • avoid generic library-route intent preloads that resolve to a different static route and lock up the page

Fixes #1200

Testing

  • pnpm test
  • hovered both reciprocal landing-page links and confirmed their intent preloads complete without router warnings or page freezes
  • navigated from Highlight to Markdown through the companion card

Summary by CodeRabbit

  • Bug Fixes
    • Updated the “Explore Markdown” and “Explore Highlight” links to open the latest version of each library.
    • Improved navigation consistency between the Highlight and Markdown landing pages.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com 53de61c Commit Preview URL

Branch Preview URL
Aug 31 2026, 11:56 AM

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 93a6faf8-120c-48f8-b9d6-bcae5c83d9d2

📥 Commits

Reviewing files that changed from the base of the PR and between a9c2075 and 53de61c.

📒 Files selected for processing (2)
  • src/components/landing/HighlightLanding.tsx
  • src/components/landing/MarkdownLanding.tsx

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The landing page companion links now target explicit /markdown/latest and /highlight/latest routes instead of generic library routes.

Changes

Landing page route corrections

Layer / File(s) Summary
Explicit latest-version routes
src/components/landing/HighlightLanding.tsx, src/components/landing/MarkdownLanding.tsx
The companion links now use versioned Markdown and Highlight routes with version: 'latest'.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 53de6

The PR corrects reciprocal Markdown and Highlight landing-page links so navigation and preloading use the intended dedicated routes; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: sukvvon, tannerlinsley

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: preventing crashes from the Markdown and Highlight landing links.
Linked Issues check ✅ Passed The changes update both reciprocal landing links to dedicated versioned route templates. This directly addresses the hover crash and unresponsive-page behavior described in issue #1200.
Out of Scope Changes check ✅ Passed The pull request contains only two targeted link-route changes in the Markdown and Highlight landing components. The changes are directly related to issue #1200.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/1200-library-cross-link-prefetch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tannerlinsley tannerlinsley added the source-audit Tracked by the automated source audit label Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

source-audit Tracked by the automated source audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hovering link on Markdown and Highlight landing pages causes page crash

2 participants