Sync main with short-io-app, add tests and CI - #1
Open
rajpootathar wants to merge 15 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR integrates encrypted links functionality and updates the README to document the new secure URL features. The changes include updates to intent handling using lifecycleScope, the introduction of a new Compose button for creating secure URLs, and an upgrade of the Short.io Android SDK dependency.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/main/java/com/github/shortioapp/MainActivity.kt | Updates intent handling and adds a new secure URL creation Composable function. |
| app/build.gradle.kts | Upgrades the Short.io Android SDK dependency version. |
| README.md | Documents the new secure URL feature and provides sample usage. |
rajpootathar
changed the title
rajpootathar
marked this pull request as draft
August 12, 2025 15:25
rajpootathar
marked this pull request as ready for review
August 15, 2025 11:19
gugu
approved these changes
Aug 26, 2026
Replaces the Android Studio placeholder with four tests covering launch, SDK initialization, empty initial state, and secure URL generation. Runs on the JVM under Robolectric rather than an emulator. Only the secure URL button is clicked: createSecure is local AES-GCM, while the other two buttons call the live Short.io API and must never run from a test.
Resolves the SDK from JitPack as its own step so an outage reads as a
dependency failure, then assembles, runs the unit tests, and compiles the
instrumented tests without an emulator.
Lint is not run: the sample ships android:host="{your_domain}" as a
fill-in-the-blank placeholder, which lint reports as an AppLinkUrlError.
Also ignores .idea and .kotlin, and untracks the .idea files already
committed.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: Comment |
rajpootathar
changed the title
Checkout leaves a repo-scoped token in .git/config for the rest of the job; nothing here pushes, so it does not need one.
The main ruleset requires a status check called test; the job above reports as build, so nothing satisfied it and PRs stayed blocked.
The button displayed securedShortUrl on its own, which is only the "#<key>" fragment, so the screen showed a bare AES key labelled as a URL and the ciphertext went nowhere but logcat. It now shortens the ciphertext and appends the key to the returned short URL. createShortLink blocks, so the work moves off the Compose main dispatcher onto a background thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
mainup to date withshort-io-app, and adds tests and CI.Sample app changes
Already in this branch, not yet on
main:Tests
Four tests replacing
assertEquals(4, 2 + 2):onCreateinitializes the SDKThey run on the JVM under Robolectric, so no emulator is needed.
Only the secure URL button is clicked.
createSecureis local AES-GCM with nonetwork. The other two buttons call the live Short.io API, so a test must never
press them.
CI
One job: resolve the SDK from JitPack, assemble, run unit tests, compile the
instrumented tests. Resolution is a separate step so a JitPack outage reads as a
dependency failure rather than a compile error.
No lint: the sample ships
android:host="{your_domain}"as a placeholder, whichlint reports as an error.
Notes
v1.0.9. Bump it oncev1.1.0is tagged (Sync main with short-io-sdk, add SDK test suite and CI android-sdk#4)..ideafiles are now ignored and untracked.