Use the proxy's online mode state on entity-metadata-rewrite server switches - #875
Merged
Merged
Conversation
…witches Upstream #3998 (dc538cb2) took the initial-login half of our temporary "Use proxy online mode state" patch, so that patch was dropped in the last upstream update. The other half applied to our own code: the Login packet that the disable_entity_metadata_rewrite path re-sends on a server switch, which went back to reporting the backend's login.isOnlineMode(). With an online-mode proxy in front of offline-mode backends the client was told true at login and false on every switch, so it would not prepare chat keys consistently. Report the pending connection's value at both sites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream #3998 (
dc538cb2) took the initial-login half of our temporary "Use proxy online mode state" patch, so that patch was dropped in the last upstream update (#874). Its other half applied to our own code, not upstream's: theLoginpacket that thedisable_entity_metadata_rewritepath re-sends on a server switch, in0043-Provide-an-option-to-disable-entity-metadata-rewriti.patch. That line went back to reporting the backend'slogin.isOnlineMode().With an online-mode proxy in front of offline-mode backends, the client is told
trueat login (upstream's site) andfalseon every switch through that path, so it does not prepare chat keys consistently. Only installs running with entity metadata rewriting disabled are affected; the default path sends aRespawnand never hit this.This reports
user.getPendingConnection().isOnlineMode()at that site too, restoring the comment explaining why.Patches apply cleanly and
./waterfall bbuilds green on JDK 21. (The build fails on this machine's JDK 25 withrelease version 17 not supported— pre-existing and unrelated to this change.)