refactor(auth): separate sandbox identity from TLS - #3110
Open
drew wants to merge 1 commit into
Open
Conversation
drew
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 1, 2026 19:58
|
🌿 Preview your docs: https://nvidia-preview-pr-3110.docs.buildwithfern.com/openshell |
19 tasks
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
force-pushed
the
2417-certless-sandbox-tls/drew
branch
from
September 1, 2026 20:18
61eb402 to
d07b66a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Separate sandbox identity from transport security. Sandboxes now authenticate the gateway with its CA certificate and authenticate their own RPCs with the bearer-token bootstrap contract landed in #2968, so no user client certificate or private key is exposed inside a sandbox.
Gateway mTLS user authentication remains configurable through
[openshell.gateway.mtls_auth]and no longer depends on the selected compute driver. This keeps the driver-free gateway free of first-party driver policy and addresses the authentication concern raised during review of #2823.Related Issue
Related to #2417.
Follow-up to #2968; addresses review feedback from #2823.
Changes
guest_tls_cafor sandbox-to-gateway TLS across Docker, Podman, Kubernetes, and VM driversTesting
mise run pre-commitpassesAdditional verification:
cargo check -p openshell-core -p openshell-server -p openshell-driver-docker -p openshell-driver-podman -p openshell-driver-kubernetes -p openshell-driver-vm --all-targetsopenshell-server,openshell-sandbox, and the Docker, Podman, Kubernetes, and VM compute driversmise run e2e:dockermise run ci(Rust and other completed lanes passed; the Go lane encountered three pre-existing gateway-list tests that enumerate the host's installed/etc/openshell/gateways/defaultin addition to isolated test fixtures)Checklist