feat(test-guest): allow copy mode overrides - #3091
Open
elezar wants to merge 1 commit into
Open
Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 1, 2026 14:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow Nix test-guest
--copyentries to include an optional bare permission mode suffix. When the suffix is omitted, the runner preserves the host file mode; when present, it passes the mode through to guest-sideinstall -m.Related Issue
No issue required: localized test VM infrastructure flag requested directly.
Changes
--copyasSRC:DEST[:MODE].MODEis omitted.Testing
bash -n nix/test-guest/run.shgit diff --check755,0755, and invalid mode deferralmise run pre-commitpasses, attempted vianix develop --command mise run pre-commit; timed out after 120s while building the dev environmentChecklist