Correct salary column size estimation in table design - #60
Open
HAMIDOUN Houssain (Hossain007) wants to merge 1 commit into
Open
Correct salary column size estimation in table design#60HAMIDOUN Houssain (Hossain007) wants to merge 1 commit into
HAMIDOUN Houssain (Hossain007) wants to merge 1 commit into
Conversation
Updated the estimated storage size for the Salary column in the Employee table per this documentation https://learn.microsoft.com/en-us/sql/t-sql/data-types/decimal-and-numeric-transact-sql?view=sql-server-ver17 it is 9 storage bytes for precision 10-19 not 5
Author
|
i forgot to modify the calculation for the total estimated row size but that needs to be corrected as well if the PR is accepted :) |
HAMIDOUN Houssain (Hossain007)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
corrected the estimated storage size for the Salary column in the Employee table per this documentation https://learn.microsoft.com/en-us/sql/t-sql/data-types/decimal-and-numeric-transact-sql?view=sql-server-ver17
it is 9 storage bytes for precision 10-19 not 5
Before requesting or performing a merge in upstream:
https://learn.microsoft.com/help/contribute/contribute-how-to-write-pull-request-quality-criteria?branch=main