-
-
Notifications
You must be signed in to change notification settings - Fork 13
Add JVM credential sign-in and account linking support #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TomislavMladenov
wants to merge
1
commit into
GitLiveApp:master
Choose a base branch
from
SiereSoft:jvm-auth-credential-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 changes: 69 additions & 3 deletions
72
src/main/java/com/google/firebase/auth/AuthCredential.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,75 @@ | ||
| package com.google.firebase.auth; | ||
|
|
||
| import kotlin.NotImplementedError; | ||
| import java.net.URLEncoder; | ||
| import java.nio.charset.StandardCharsets; | ||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| public abstract class AuthCredential { | ||
| private final String provider; | ||
| private final String idToken; | ||
| private final String accessToken; | ||
| private final String rawNonce; | ||
|
|
||
| protected AuthCredential(String provider) { | ||
| this(provider, null, null, null); | ||
| } | ||
|
|
||
| protected AuthCredential(String provider, String idToken, String accessToken, String rawNonce) { | ||
| this.provider = requireValue(provider, "provider"); | ||
| this.idToken = optionalValue(idToken, "idToken"); | ||
| this.accessToken = optionalValue(accessToken, "accessToken"); | ||
| this.rawNonce = optionalValue(rawNonce, "rawNonce"); | ||
|
|
||
| if (this.rawNonce != null && this.idToken == null) { | ||
| throw new IllegalArgumentException("An ID token is required when a raw nonce is supplied."); | ||
| } | ||
| } | ||
|
|
||
| public class AuthCredential { | ||
| public String getProvider() { | ||
| throw new NotImplementedError(); | ||
| return provider; | ||
| } | ||
|
|
||
| public String getSignInMethod() { | ||
| return provider; | ||
| } | ||
|
|
||
| String toIdpPostBody() { | ||
| List<String> values = new ArrayList<>(); | ||
| values.add(formValue("providerId", provider)); | ||
| if (idToken != null) { | ||
| values.add(formValue("id_token", idToken)); | ||
| } | ||
| if (accessToken != null) { | ||
| values.add(formValue("access_token", accessToken)); | ||
| } | ||
| if (rawNonce != null) { | ||
| values.add(formValue("nonce", rawNonce)); | ||
| } | ||
| return String.join("&", values); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return getClass().getSimpleName() + "{provider='" + provider + "'}"; | ||
| } | ||
|
|
||
| static String requireValue(String value, String name) { | ||
| if (value == null || value.trim().isEmpty()) { | ||
| throw new IllegalArgumentException(name + " must not be null or blank."); | ||
| } | ||
| return value; | ||
| } | ||
|
|
||
| static String optionalValue(String value, String name) { | ||
| if (value != null && value.trim().isEmpty()) { | ||
| throw new IllegalArgumentException(name + " must not be blank."); | ||
| } | ||
| return value; | ||
| } | ||
|
|
||
| private static String formValue(String name, String value) { | ||
| return URLEncoder.encode(name, StandardCharsets.UTF_8) + "=" + | ||
| URLEncoder.encode(value, StandardCharsets.UTF_8); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defaulting to
Dispatchers.Defaultmoves allHandler.post/ listener callbacks onto a multi-threaded pool.The
android.os.Handlerstub is what the bundled Firestore/Database AARs use to deliver callbacks. On Android these run in order on a single looper thread, and previouslyDispatchers.Main(Swing/JavaFX) gave the same single-thread guarantee. WithSupervisorJob() + Dispatchers.Default, twoHandler.post(...)calls can run concurrently and out of order on different worker threads, so snapshot/child-event listeners can observe interleaved or reordered events.It is also a silent behavior change for existing consumers: callbacks that used to arrive on the UI thread (Compose Desktop / Swing) now arrive on a
DefaultDispatcher-workerand must be marshalled manually.Suggest making the default single-threaded (e.g.
Dispatchers.Default.limitedParallelism(1)or a dedicated single-thread executor) and calling out the change in the README.Generated by Claude Code