cam6_4_201: Age of air test tracer fixes - #1668
Open
fvitt wants to merge 13 commits into
Open
Conversation
…t file modified: src/physics/cam/aoa_tracers.F90 modified: src/physics/cam/restart_physics.F90
modified: src/physics/cam/aoa_tracers.F90
modified: bld/namelist_files/namelist_defaults_cam.xml modified: bld/namelist_files/use_cases/1850_cam_lt.xml modified: bld/namelist_files/use_cases/hist_cam_lt.xml
modified: bld/build-namelist modified: src/physics/cam/aoa_tracers.F90
modified: src/physics/cam/aoa_tracers.F90
modified: bld/build-namelist modified: bld/namelist_files/namelist_defaults_cam.xml modified: bld/namelist_files/use_cases/1850_cam_lt.xml modified: bld/namelist_files/use_cases/hist_cam_lt.xml modified: src/physics/cam/aoa_tracers.F90
Collaborator
Author
|
This is ready for review now |
peverwhee
approved these changes
Sep 4, 2026
peverwhee
left a comment
peverwhee
left a comment
Collaborator
There was a problem hiding this comment.
two small nits. Once fixed, I'm approving this for cam6_4_201
| @@ -255,12 +283,15 @@ subroutine aoa_tracers_timestep_init( phys_state ) | |||
|
|
|||
| use ppgrid, only: begchunk, endchunk | |||
Collaborator
There was a problem hiding this comment.
this use statement can be removed (it's now up at the module level)
peverwhee
changed the title
Courtney's suggestion Co-authored-by: Courtney Peverley <courtneyp@ucar.edu>
modified: src/physics/cam/aoa_tracers.F90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1654
We are still testing these mods. This might not be the final version.