Skip to content

fix: install clippy for main branch cache checks - #2217

Merged
richiemcilroy merged 1 commit into
mainfrom
desktop-optimisations-etc
Sep 3, 2026
Merged

fix: install clippy for main branch cache checks#2217
richiemcilroy merged 1 commit into
mainfrom
desktop-optimisations-etc

Conversation

@richiemcilroy

@richiemcilroy richiemcilroy commented Sep 3, 2026

Copy link
Copy Markdown
Member

The main-only Rust cache jobs call cargo clippy without installing Clippy for Rust 1.88.0. The Windows cache job failed with cargo-clippy.exe is not installed, after its debug build and release-profile check had passed.

Install the component explicitly, matching the dedicated Clippy job. This changes one workflow line and does not change desktop code. It follows the validation of #2215, which is already merged.

Validation: YAML parsing passed; the parsed workflow differs only by the added component. Actionlint reports the same eight pre-existing diagnostics before and after, with no new diagnostics. The dedicated Windows Clippy job passed on the same source and toolchain with this component installed. The repaired main-only cache job needs confirmation in its next main run.

Greptile Summary

This PR installs Clippy explicitly for the main-branch Rust cache matrix so its existing cargo clippy step can run with Rust 1.88.0.

  • Adds components: clippy to the cache job’s Rust toolchain setup.
  • Leaves desktop source and runtime behavior unchanged.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
.github/workflows/ci.yml Adds the missing Clippy component to the Rust cache matrix using the same toolchain configuration pattern already used by the dedicated Clippy job.

Reviews (2): Last reviewed commit: "fix: install clippy for main branch cach..." | Re-trigger Greptile

@richiemcilroy

Copy link
Copy Markdown
Member Author

hey @greptileai, please re-review the PR

@richiemcilroy
richiemcilroy merged commit 32dd2b3 into main Sep 3, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant