Skip to content

Vulnerability in dependency diff ^7.0 causes "npm audit" to fail #577

Description

@SunMar

A (low) security vulnerability was found in the dependency diff. It was fixed in version 8.0.3, but this package still depends on ^7.0. See kpdecker/jsdiff#644 and GHSA-73rr-hh4g-fpgx for details.

Is it possible to bump the dependency to ^8.0 or ^7.0 || ^8.0? The release notes https://github.com/kpdecker/jsdiff/blob/master/release-notes.md look like from a functional perspective not a lot changed, but I have no clue how those changes might impact diff2html. Based on a quick search I can only find a direct dependency in render-utils.ts.

import * as jsDiff from 'diff';

Due to the vulnerability, npm audit now fails when diff2html is installed:

docker run --rm -it node:24 bash
cd /opt
npm install diff2html
npm audit

Output:

# npm audit report

diff  <8.0.3
jsdiff has a Denial of Service vulnerability in parsePatch and applyPatch - https://github.com/advisories/GHSA-73rr-hh4g-fpgx
fix available via `npm audit fix --force`
Will install diff2html@0.1.9, which is a breaking change
node_modules/diff
  diff2html  >=0.2.0-1
  Depends on vulnerable versions of diff
  node_modules/diff2html

2 low severity vulnerabilities

To address all issues (including breaking changes), run:
  npm audit fix --force

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions