Skip to content

Commit 194f104

Browse files
Merge branch 'main' into exclude-lines-support
2 parents c0e6392 + 1c25163 commit 194f104

1 file changed

Lines changed: 4 additions & 10 deletions

File tree

tests/test_xdist.py

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -221,16 +221,10 @@ def test_xdist_four_workers(tmp_path):
221221

222222
# ---------------------------------------------------------------------------
223223
# Regression tests for modules imported by a conftest.py before pytest_configure()
224-
# runs in an xdist worker (issue #84's "pre-imported modules" report). Adapted
225-
# from PR #85 (https://github.com/plasma-umass/slipcover/pull/85, author @nurikk),
226-
# who first diagnosed this gap and prototyped a fix by retroactively instrumenting
227-
# already-imported objects after the fact. Unfortunately, that approach has some
228-
# significant issues: on Python <3.12 the rewritten bytecode wasn't reinstalled,
229-
# and on 3.12+ branch coverage came back as a false 100% (no AST-level branch
230-
# preinstrumentation for modules that were already compiled). The fix here takes
231-
# a different angle: activate ImportManager earlier, before conftest.py is ever
232-
# read, so these modules go through the normal instrumentation path from the
233-
# start and need no after-the-fact repair.
224+
# runs in an xdist worker (issue #84's "pre-imported modules" report). The fix:
225+
# activate ImportManager earlier, before conftest.py is ever read, so these
226+
# modules go through the normal instrumentation path from the start and need
227+
# no after-the-fact repair.
234228
# ---------------------------------------------------------------------------
235229

236230

0 commit comments

Comments
 (0)